touch segfaults on 32 bits architectures since 0.6 -> 0.7 update

[seb128]

The issue is showing as a tar build failure in Ubuntu resolute on armhf and i386

# touch -d "0000-01-01T00:00:00" bug                    

thread 'main' (104766) panicked at src/uu/touch/src/touch.rs:627:30:
called `Result::unwrap()` on an `Err` value: TryFromIntError(())
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted                    (core dumped) touch -d "0000-01-01T00:00:00" bug

the same command works with gnutouch or when downgrading from rust-coreutils 0.7.0-0ubuntu1 to 0.6.0-0ubuntu1

[sylvestre]

Thanks for the report!

This is a known issue on 32-bit architectures. The root cause is in commit 8c06c48 which used .try_into().unwrap() to convert i64 timestamps to i32 (what nix::TimeSpec::new() expects on 32-bit targets). For dates like 0000-01-01, the Unix timestamp (~-62 billion) overflows an i32, causing the panic.

This has already been fixed on main by commit 7ade5c1 ("touch: replace nix by rustix"), which uses rustix::fs::Timespec with native i64 for tv_sec — no more lossy conversion.

The fix will be included in the next release.

[seb128]

@sylvestre ah, good to know, thanks!

[oech3]

You can replace your system binary with https://github.com/uutils/coreutils/releases/tag/latest-commit if you hurry.

[xtqqczze]

This has already been fixed on main by commit 7ade5c1 ("touch: replace nix by rustix"), which uses rustix::fs::Timespec with native i64 for tv_sec — no more lossy conversion.

@sylvestre it would be good to have a regression test

[sylvestre]

indeed!