How to remove unsafe env::{set_var, remove_var} (at least for 1 thread utility)?

[oech3]

There are many unsafe blocks e.g.
https://github.com/search?q=repo%3Auutils%2Fcoreutils+env%3A%3Aset_var&type=code
https://github.com/search?q=repo%3Auutils%2Fcoreutils+env%3A%3Aremove_var&type=code

Can we remove them or use without unsafe{} at least from one-thread utility?

[cakebaker]

I think you can't remove unsafe from them. It was a breaking change introduced with Rust 2024: https://doc.rust-lang.org/edition-guide/rust-2024/newly-unsafe-functions.html

[oech3]

Are everything of them needed for the process itself, or only for sub-process?

[sylvestre]

just create a function uucore to do it. we will have only one unsafe

[oech3]

I think it is fake-safe function which is actually thread unsafe.

[oech3]

can we use Command::env at some cases?

[Franklin-Qi]

std::process::Command::env() might be a good approach. It is relatively safe, as child processes will inherit the modified environment and will not affect the current process.