tail: fix big number handling and error message quoting #10155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the test cases in tail.pl I concerned that I could find equivalent examples in our integration tests that expect different results. It turns out that this is because the behavior of tail actually changed in 9.6 to clamp large integers instead of throwing an error, so some of our code was no longer valid.
Because we already have the helper functions that follow this behavior the change is very simple, changing
parse_signed_numtoparse_signed_num_maxand then changing:to
Then there was an error message that had an extra quote and now all of the
tail.pltest cases are passing