Skip to content

Conversation

@w007878
Copy link
Contributor

@w007878 w007878 commented Jan 19, 2026

resolves #10361

Use the same approach for base64/base32

@sylvestre
Copy link
Contributor

please add tests to make sure we don't regress in the future

@w007878 w007878 marked this pull request as draft January 19, 2026 21:08
@w007878
Copy link
Contributor Author

w007878 commented Jan 19, 2026

please add tests to make sure we don't regress in the future

Thanks. On it.

@w007878 w007878 marked this pull request as ready for review January 19, 2026 21:17
@w007878 w007878 changed the title fix: add "about" and "usage" for dir and vdir fix: add "about" and "usage" for dir Jan 19, 2026
@w007878 w007878 changed the title fix: add "about" and "usage" for dir fix (dir): add "about" and "usage" instead of being "ls" Jan 19, 2026
@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

Merging this PR will degrade performance by 3.52%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 280 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory du_wide_tree[(5000, 500)] 1.2 MB 1.2 MB -3.52%
Memory cp_large_file[16] 116.9 KB 103 KB +13.5%

Comparing w007878:fix/dir-vdir-help (d42681a) with main (b302bbe)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@w007878 w007878 changed the title fix (dir): add "about" and "usage" instead of being "ls" dir: add "about" and "usage" instead of being "ls" Jan 19, 2026
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/dd/stderr. tests/dd/stderr is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tac/tac-2-nonseekable. tests/tac/tac-2-nonseekable is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/follow-stdin. tests/tail/follow-stdin is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/stderr is no longer failing!
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit da4d846 into uutils:main Jan 20, 2026
156 of 158 checks passed
mattsu2020 pushed a commit to mattsu2020/coreutils that referenced this pull request Jan 23, 2026
* fix: add "about" and "usage" for dir and vdir

* fix import

* revert changes on vdir. focus on dir first

* revert import on vdir

* add test

* Update en-US.ftl

* fix fmt

* revert vdir

* precommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dir, ls: dir --help says I am ls

2 participants