build-gnu.sh: remove workaround for timeout/yes #10505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that uutils#7252 is fixed this workaround is not needed any more: This is a partial revert of uutils@fac6c29 ("util/build-gnu.sh: Bypass timeout/yes SIGPIPE handling bug") This is a revert of uutils@5004d4b ("build-gnu: replace `timeout` for `tests/tail/follow-stdin.sh`") Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
Collaborator
Author
|
@ChrisDryden FYI I'm creating this PR as follow-up of #10254 (comment) |
|
GNU testsuite comparison: |
There was a problem hiding this comment.
Pull request overview
This PR removes a now-unnecessary workaround in util/build-gnu.sh that patched GNU test scripts to avoid a SIGPIPE-handling bug in uutils yes/timeout, which has since been fixed (issue #7252).
Changes:
- Remove detection of the system
yesbinary inbuild-gnu.sh. - Remove
sedrewrites that forcedtests/tail/follow-stdin.shandinit.cfgto use the systemtimeout/yesinstead of the uutils versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #7252 is fixed this workaround is not needed any more.
This is a partial revert of fac6c29 ("util/build-gnu.sh: Bypass timeout/yes SIGPIPE handling bug")
This is a revert of 5004d4b ("build-gnu: replace
timeoutfortests/tail/follow-stdin.sh")