Skip to content

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 4, 2026

Address all suggestions of clippy::trivially_copy_pass_by_ref

Seems cleaner, and I wonder if perf would be affected

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 4, 2026

Merging this PR will degrade performance by 3.3%

❌ 1 regressed benchmark
✅ 283 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 26.8 ms 27.7 ms -3.3%

Comparing nyurik:refs (c0f28ba) with main (26a29ca)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
Copy link
Contributor

Could you please update the clippy configuration to make sure we don't regress in the future

@nyurik
Copy link
Contributor Author

nyurik commented Feb 4, 2026

Could you please update the clippy configuration to make sure we don't regress in the future

already done -- this PR removes trivially_copy_pass_by_ref in Cargo.toml

@sylvestre
Copy link
Contributor

i missed it, sorry

…nces

Address all suggestions of `clippy::trivially_copy_pass_by_ref`

Seems cleaner, and I wonder if perf would be affected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants