test/cksum: implement test_signed_checksums#10714
Conversation
|
GNU testsuite comparison: |
|
This test is meant to re-implement the GNU test "signed" in the You can take a look at it here and replicate it. |
d8dfb43 to
715e10b
Compare
|
Thanks! i should have implemented the correct testcase now, feel free to let me know if something still needs to change |
Please be careful suggesting this. The test suite is still GPLv3+, and one might interpret "replicate" as creating a verbatim/modified copy of the original. |
|
GNU testsuite comparison: |
|
I will +1 Collin. please don't read the GNU code to implement this one |
|
I made sure not to copy anything from the GNU implementation because of the warning in CONTRIBUTING.md, if it's still too similar however i will change it if needed |
|
Fair enough, I didn't think that was a problem for tests as well. I'll remember it. |
|
@sylvestre How about submitting tests to GNU as you did? |
|
@oech3 i am porting our MIT code/test to GPLv3 |
Replaced a
todo!()test with a working (and passing) implementation