Skip to content

test/cksum: implement test_signed_checksums#10714

Merged
sylvestre merged 1 commit intouutils:mainfrom
0xMillyByte:test/test_signed_checksum
Feb 4, 2026
Merged

test/cksum: implement test_signed_checksums#10714
sylvestre merged 1 commit intouutils:mainfrom
0xMillyByte:test/test_signed_checksum

Conversation

@0xMillyByte
Copy link
Contributor

Replaced a todo!() test with a working (and passing) implementation

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@RenjiSann
Copy link
Collaborator

This test is meant to re-implement the GNU test "signed" in the tests/cksum-c.sh test of the GNU testsuite.

You can take a look at it here and replicate it.

@0xMillyByte 0xMillyByte force-pushed the test/test_signed_checksum branch from d8dfb43 to 715e10b Compare February 4, 2026 14:58
@0xMillyByte
Copy link
Contributor Author

Thanks! i should have implemented the correct testcase now, feel free to let me know if something still needs to change

@collinfunk
Copy link

collinfunk commented Feb 4, 2026

This test is meant to re-implement the GNU test "signed" in the tests/cksum-c.sh test of the GNU testsuite.

You can take a look at it here and replicate it.

Please be careful suggesting this. The test suite is still GPLv3+, and one might interpret "replicate" as creating a verbatim/modified copy of the original.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

I will +1 Collin. please don't read the GNU code to implement this one

@0xMillyByte
Copy link
Contributor Author

I made sure not to copy anything from the GNU implementation because of the warning in CONTRIBUTING.md, if it's still too similar however i will change it if needed

@RenjiSann
Copy link
Collaborator

RenjiSann commented Feb 4, 2026

Fair enough, I didn't think that was a problem for tests as well. I'll remember it.

@oech3
Copy link
Contributor

oech3 commented Feb 4, 2026

@sylvestre How about submitting tests to GNU as you did?

@sylvestre
Copy link
Contributor

@oech3 i am porting our MIT code/test to GPLv3
this way is fine

@sylvestre sylvestre merged commit c3eb85f into uutils:main Feb 4, 2026
170 of 173 checks passed
@0xMillyByte 0xMillyByte deleted the test/test_signed_checksum branch February 4, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants