ptx: fix panic when truncation string/keyword contain multibyte Unicode#10836
Merged
cakebaker merged 2 commits intouutils:mainfrom Feb 12, 2026
Merged
ptx: fix panic when truncation string/keyword contain multibyte Unicode#10836cakebaker merged 2 commits intouutils:mainfrom
cakebaker merged 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Contributor
|
#10749 is still active. |
Contributor
|
Also |
abendrothj
pushed a commit
to abendrothj/coreutils
that referenced
this pull request
Feb 17, 2026
…de (uutils#10836) Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10750
Summary
Fixes a
ptxpanic triggered by non-ASCII input (e.g., emoji) when calculating the “after” chunk width.Root cause:
max_after_sizewas computed using byte lengths (.len()), while the output chunking logic operates on characters. With multibyte Unicode, this can makemax_after_sizesmaller than the number of characters actually appended, trippingassert!(max_after_size >= after.len()).