sort: Replace malloc and 0 fill with huge reserve & min 0 fill#10975
Open
oech3 wants to merge 1 commit intouutils:mainfrom
Open
sort: Replace malloc and 0 fill with huge reserve & min 0 fill#10975oech3 wants to merge 1 commit intouutils:mainfrom
oech3 wants to merge 1 commit intouutils:mainfrom
Conversation
Merging this PR will improve performance by 64.53%
Performance Changes
Comparing 
Footnotes
|
xtqqczze
reviewed
Feb 16, 2026
| } else if estimated == 1 { | ||
| const LINE_LEN_HINT: usize = 32; | ||
| estimated = (read.len() / LINE_LEN_HINT).max(1); | ||
| const LINE_LEN_HINT: usize = 128; |
Contributor
There was a problem hiding this comment.
@mattsu2020 how did you decide to use 32 for LINE_LEN_HINT in the existing code?
Contributor
Author
There was a problem hiding this comment.
We can define const MAYBE_LN_CACHE_SIZE: usize for everywhere.
oech3
force-pushed
the
sort-malloc0
branch
4 times, most recently
from
e875422 to
204214a
Compare
Contributor
Author
|
I think mimalloc benchmark is useful to investigate malloc cost even if we decided to not adopt it. |
|
GNU testsuite comparison: |
sylvestre
reviewed
Feb 16, 2026
| if buffer.len() < carry_over.len() { | ||
| buffer.resize(carry_over.len() + 10 * 1024, 0); | ||
| buffer.resize(carry_over.len(), 0); | ||
| let new_len = (carry_over.len() * 2) |
Contributor
There was a problem hiding this comment.
please add a comment explaining why
xtqqczze
reviewed
Feb 16, 2026
src/uu/sort/src/chunks.rs
Outdated
| GeneralBigDecimalParseResult, GlobalSettings, Line, SortMode, numeric_str_cmp::NumInfo, | ||
| }; | ||
|
|
||
| const MAYBE_LN_CACHE_SIZE: usize = 64 * 1024; |
Contributor
There was a problem hiding this comment.
what does the variable name MAYBE_LN_CACHE_SIZE mean?
sort: Save RAM usage
oech3
force-pushed
the
sort-malloc0
branch
3 times, most recently
from
3be05e9 to
635e73f
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found at #10954