id: fix selinux/smack platform guards for non-Linux platforms#10995
Closed
naoNao89 wants to merge 1 commit intouutils:mainfrom
Closed
id: fix selinux/smack platform guards for non-Linux platforms#10995naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
Note: I have a draft PR that would apply this more generally by defining a cfg alias: selinux: { all(feature = "feat_selinux", any(target_os = "android", target_os = "linux"))see #10444 |
Contributor
Author
|
tkss |
Contributor
|
That's not to say this isn't worth considering on its own. Anyway, since you've closed this I will try get #10444 ready for review. |
Contributor
Author
|
heh, I thought your PR covered this, so I closed my PR :v |
Contributor
|
Actually, my PR doesn't cover this... |
Contributor
|
I've added fixes for selinux/smack feature gates to #10444 |
Contributor
Author
|
tkss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pre-commit hook failures on non-Linux platforms by adding proper
#[cfg(target_os = "linux")]guards to selinux/smack feature gates.The
uucorecrate only exposes these modules on Linux/Android, so the caller must match those platform restrictions.