wc: stop processing --files0-from input after stdout write failure#11023
Merged
cakebaker merged 2 commits intouutils:mainfrom Feb 19, 2026
Merged
wc: stop processing --files0-from input after stdout write failure#11023cakebaker merged 2 commits intouutils:mainfrom
cakebaker merged 2 commits intouutils:mainfrom
Conversation
When wc encounters a write error to stdout (e.g., when stdout is redirected to /dev/full), it should stop processing immediately rather than continuing to process remaining files. This matches GNU wc behavior and prevents unnecessary processing after the output is already broken.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
wc --files0-from=-so it stops processing additional inputs after a stdout write failure.With an unbounded
--files0-fromstream (e.g.yes /dev/null | tr '\n' '\0') and a failing stdout write,wckept iterating and repeatedly printed:wc: failed to print result for /dev/null: No space left on deviceThis could lead to the process not exiting as expected.
Fixes #11009.
Root cause
In the per-input loop,
print_stats(...)errors were reported but not treated as a terminal condition.As a result,
wccontinued consuming more paths from--files0-from=-even after stdout was no longer writable.Changes
src/uu/wc/src/wc.rswc-error-failed-to-print-result, return fromwc(...)immediately.tests/by-util/test_wc.rstest_files0_stops_after_stdout_write_error/dev/fulland verifies that:failed to print result for /dev/nullis emitted only once.