Skip to content

shuf: Reduce malloc, perf +4%#11219

Merged
RenjiSann merged 1 commit intouutils:mainfrom
oech3:shuf-malloc
Mar 7, 2026
Merged

shuf: Reduce malloc, perf +4%#11219
RenjiSann merged 1 commit intouutils:mainfrom
oech3:shuf-malloc

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Mar 6, 2026

mimalloc complained

@oech3 oech3 changed the title shuf: Redice malloc shuf: Reduce malloc Mar 6, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 6, 2026

Merging this PR will improve performance by 4.02%

⚡ 2 improved benchmarks
✅ 296 untouched benchmarks
⏩ 48 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory shuf_repeat_sampling[50000] 1.2 MB 1.1 MB +4.02%
Simulation shuf_repeat_sampling[50000] 4.7 ms 4.5 ms +4%

Comparing oech3:shuf-malloc (bb1ede3) with main (f0c71b2)2

Open in CodSpeed

Footnotes

  1. 48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (54cfd30) during the generation of this report, so f0c71b2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@oech3 oech3 force-pushed the shuf-malloc branch 2 times, most recently from e3a45b1 to bb1ede3 Compare March 6, 2026 16:30
@oech3 oech3 changed the title shuf: Reduce malloc shuf: Reduce malloc, perf +4% Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/pr/bounded-memory is now passing!

@oech3 oech3 marked this pull request as ready for review March 6, 2026 17:02
@RenjiSann RenjiSann merged commit 9e26f3c into uutils:main Mar 7, 2026
162 of 163 checks passed
@oech3 oech3 deleted the shuf-malloc branch March 7, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants