Skip to content

GNUmakefile: Swap uname -s with rustc --print host-tuple for cross-build and MSYS#11260

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:make-rustc
Open

GNUmakefile: Swap uname -s with rustc --print host-tuple for cross-build and MSYS#11260
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:make-rustc

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Mar 9, 2026

Closes #11252 @ognevny

@ognevny
Copy link
Contributor

ognevny commented Mar 9, 2026

after brief look it seems that using rustc target is better!

@oech3
Copy link
Contributor Author

oech3 commented Mar 9, 2026

I'm happy since x86_64-pc-cygwin is not x86_64-pc-windows-cygwin.

@ognevny
Copy link
Contributor

ognevny commented Mar 9, 2026

I'm happy since x86_64-pc-cygwin is not x86_64-pc-windows-cygwin.

cygwin is cygwin, windows is windows. for compilers it makes sense

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

@oech3
Copy link
Contributor Author

oech3 commented Mar 9, 2026

We actually should extract utils from cargo metadata --format-version 1 --no-deps | jq ... but jq dep was rejected.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2026

Merging this PR will not alter performance

✅ 298 untouched benchmarks
⏩ 48 skipped benchmarks1


Comparing oech3:make-rustc (52baafa) with main (5a912a7)

Open in CodSpeed

Footnotes

  1. 48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review March 9, 2026 19:01
@sylvestre
Copy link
Contributor

can we add a task in the ci to make sure we won't regress? thanks

@oech3

This comment was marked as outdated.

@oech3

This comment was marked as off-topic.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3 oech3 force-pushed the make-rustc branch 3 times, most recently from e2ad008 to c9fd7c7 Compare March 10, 2026 08:43
@oech3
Copy link
Contributor Author

oech3 commented Mar 10, 2026

added regression test.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GNUmakefile: OS should be based on rustc --print host-tuple and CARGO_BUILD_TARGET

3 participants