Skip to content

ls: bump uutils_term_grid to 0.8.0#11264

Open
sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre:uutils_term_grid
Open

ls: bump uutils_term_grid to 0.8.0#11264
sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre:uutils_term_grid

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Mar 9, 2026

it should fail until we update uutils_term_grid

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

@sylvestre sylvestre changed the title ls: add regression test for uutils_term_grid off-by-one in column layout ls: bump uutils_term_grid to 0.8.0 Mar 9, 2026
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

sylvestre added a commit to sylvestre/coreutils-1 that referenced this pull request Mar 9, 2026
@sylvestre
tests: ls: add test for fix expected output for single-row across layout
4ce29c0 
* tests/ls/across-one-row.sh: add test to cover this.
  Found:
  uutils/coreutils#11264
  eza-community/eza#1738
@sylvestre sylvestre mentioned this pull request Mar 9, 2026
Open
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/pid-pipe. tests/tail/pid-pipe is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@sylvestre sylvestre marked this pull request as ready for review March 9, 2026 23:06
cakebaker
cakebaker reviewed Mar 10, 2026
View reviewed changes
tests/by-util/test_ls.rs
.arg("--width=96")
.succeeds()
.stdout_only(
"Desktop\t Documents Downloads Music Pictures\tPublic\tTemplates Videos code\n",
Copy link
Contributor

@cakebaker cakebaker Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GNU ls doesn't seem to use tabs:

$ tabs 16
$ LC_ALL=C ls --width=96 ../playground/ls_11264/                                                                                         
Desktop  Documents  Downloads  Music  Pictures  Public  Templates  Videos  code
$ LC_ALL=C cargo run -q ls --width=96 ../playground/ls_11264/
Desktop          Documents  Downloads  Music  Pictures          Public          Templates  Videos  code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @cakebaker