tac: avoid mmap on regular files to prevent SIGBUS on truncation#11326
Open
mango766 wants to merge 1 commit intouutils:mainfrom
Open
tac: avoid mmap on regular files to prevent SIGBUS on truncation#11326mango766 wants to merge 1 commit intouutils:mainfrom
mango766 wants to merge 1 commit intouutils:mainfrom
Conversation
When a file is memory-mapped and then truncated by another process while tac is reading it, accessing the now-invalid mapped region triggers SIGBUS and crashes the process. This is particularly problematic for log rotation scenarios where tac might read logs that are being rotated/truncated concurrently. Replace the mmap-based file reading with read_to_end(), which reads the entire file into a heap buffer. This matches how GNU tac avoids the issue. The mmap path is retained for stdin (via temp files we own), where external truncation is not a concern. Fixes uutils#9748 Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
|
GNU testsuite comparison: |
Contributor
|
please add a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tacwithread_to_end()to prevent SIGBUS crashes when input files are truncated during readtry_mmap_file()functionContext
When
tacmemory-maps a regular file and another process truncates that file concurrently, accessing the now-invalid mapped memory region triggers SIGBUS and crashes the process. This is a real concern in log rotation scenarios wheretacmight be reading logs that get rotated/truncated at the same time.GNU
tacavoids this by not directly memory-mapping untrusted input files. This PR brings the same safety to the uutils implementation by reading files into a heap buffer instead.Test plan
tactests should continue to pass (file reads, stdin, separators, regex modes)Fixes #9748
Generated with Claude Code