cksum: Match GNU behavior for digest length errors in --check mode by RenjiSann · Pull Request #11499 · uutils/coreutils

RenjiSann · 2026-03-26T00:50:35Z

This PR fixes #11202, as well as a few other related issues

github-actions · 2026-03-26T00:59:44Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)

codspeed-hq · 2026-03-26T01:05:14Z

Merging this PR will not alter performance

✅ 300 untouched benchmarks
⏩ 46 skipped benchmarks¹

_{Comparing RenjiSann:cksum-untagged-mismatch (6723393) with main (32b93b6)}

46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

AldanTanneo

lots of confusing naming regarding bit/byte length, see comments

also a minor correctness issue

AldanTanneo · 2026-03-26T01:22:25Z

src/uucore/src/lib/features/checksum/validate.rs

-        (AlgoKind::Shake128 | AlgoKind::Shake256, Some(bit_len)) => Some(bit_len.div_ceil(8)),
-        (AlgoKind::Shake128, None) => Some(sum::Shake128::DEFAULT_BIT_SIZE.div_ceil(8)),
-        (AlgoKind::Shake256, None) => Some(sum::Shake256::DEFAULT_BIT_SIZE.div_ceil(8)),
+        (AlgoKind::Blake2b | AlgoKind::Blake3, Some(byte_len)) => Some(byte_len * 8),


digest_char_length_hint now stores a bit length instead of a byte length hint? the name should probably change then.

AldanTanneo · 2026-03-26T01:25:18Z

src/uucore/src/lib/features/checksum/validate.rs

        return None;
    }

+    let byte_len_hint = bit_len_hint.map(|n| n / 8);


the division should probably be a .div_ceil(8), since for instance 4 bits still take a full byte to be represented in a truncated XOF output.

Indeed, thanks 👍

AldanTanneo · 2026-03-26T01:28:12Z

src/uucore/src/lib/features/checksum/validate.rs

+    // If the algorithm is SHA2 and no length hint was provided, compute it
+    // from the size of the expected checksum.
+    let algo_byte_len = algo_byte_len
+        .or_else(|| (algo_kind == AlgoKind::Sha2).then(|| expected_checksum.len() * 8));


wrong variable name? why do we multiply by 8 if this is a byte length

Should change the name, but when algo is Blake, this variable holds bytes 😅

#11500 is direly needed 😭

AldanTanneo · 2026-03-26T01:29:09Z

src/uucore/src/lib/features/checksum/mod.rs

+    /// When checking untagged format lines, non-XOF non-legacy algorithms
+    /// should report "improperly formatted lines" if the digest length isn't
+    /// equivalent to this.
+    pub fn expected_digest_byte_len(self) -> Option<usize> {


wrong function name: returns a bit length, not a byte length.

indeed, thanks

github-actions · 2026-03-26T10:15:21Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-03-26T11:29:38Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/cp/link-heap is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

github-actions · 2026-03-26T15:13:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/tail-n0f is now passing!

AldanTanneo

Looks good to me now (modulo the upcoming bit/byte uniformization)

cakebaker · 2026-03-27T09:06:36Z

tests/by-util/test_cksum.rs

+fn test_check_sha_tagged_no_hint() {
+    // When checking a tagged line with SHA2 but with missing length, guess
+    // from the size of the digest, and raise "improperly formatted" if the
+    // size isn't a valid SHA length.
+
+    let (at, mut ucmd) = at_and_ucmd!();
+    at.touch("a");
+    at.touch("b");
+
+    let checksum = "SHA2 (a) = d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f";
+    let invalid = "SHA2 (b) = xxxx";
+
+    ucmd.arg("-c")
+        .pipe_in(format!("{checksum}\n{invalid}"))
+        .succeeds()
+        .stdout_contains("a: OK")
+        .stderr_contains("WARNING: 1 line is improperly formatted");
+}


I think this test is incorrect because I get a failure when running the command manually with GNU cksum:

$ touch a b $ printf "SHA2 (a) = d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f\nSHA2 (b) = xxxx" | cksum -c cksum: 'standard input': no properly formatted checksum lines found $ echo $? 1

If I replace SHA2 with SHA224, however, I get the same result as in the test:

$ printf "SHA224 (a) = d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f\nSHA224 (b) = xxxx" | cksum -c a: OK cksum: WARNING: 1 line is improperly formatted

I made a mistake somewhere when testing. I'm investigating

Looks like I hallaucinated this feature, I pushed a fix

cakebaker · 2026-03-27T09:25:04Z

tests/by-util/test_cksum.rs

+
+    let (at, mut ucmd) = at_and_ucmd!();
+    at.touch("null");
+    at.write("one", "A");


I don't understand why you create this file as it isn't used afterwards.

It was meant to be the filename used in the invalid checksum, thanks for noticing it !
I changed the test a bit to use both files, and I renamed them to a and b.

cakebaker · 2026-03-27T09:25:50Z

tests/by-util/test_cksum.rs

+        .pipe_in(format!("{invalid_checksum}\n{good_checksum}"))
+        .succeeds()
+        .stdout_contains("null: OK")
+        .stdout_does_not_contain("one: FAILED")


See my previous comment.

github-actions · 2026-03-27T10:25:29Z

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

github-actions · 2026-03-27T11:07:24Z

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

cakebaker

It looks good. Can you please do a rebase and reduce the number of commits?

…ssing related issues cksum: Fix --check failing when digest length is wrong on untagged line

RenjiSann · 2026-03-27T14:01:50Z

It looks good. Can you please do a rebase and reduce the number of commits?

Did it, and rebased at the same time.

github-actions · 2026-03-27T14:10:36Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

cakebaker · 2026-03-27T15:02:14Z

Thanks!

RenjiSann requested a review from sylvestre March 26, 2026 00:50

RenjiSann self-assigned this Mar 26, 2026

AldanTanneo suggested changes Mar 26, 2026

View reviewed changes

RenjiSann force-pushed the cksum-untagged-mismatch branch from ac866ea to 59977fb Compare March 26, 2026 09:45

RenjiSann requested a review from AldanTanneo March 26, 2026 11:03

RenjiSann force-pushed the cksum-untagged-mismatch branch from 67e1369 to 4ebde21 Compare March 26, 2026 15:04

AldanTanneo approved these changes Mar 26, 2026

View reviewed changes

cakebaker reviewed Mar 27, 2026

View reviewed changes

RenjiSann added 2 commits March 27, 2026 15:01

test(cksum): Add multiple tests on check length digest validation

a8a9015

cksum: make sure --check raises "improperly formatted" for length-gue…

6723393

…ssing related issues cksum: Fix --check failing when digest length is wrong on untagged line

RenjiSann force-pushed the cksum-untagged-mismatch branch from c0c831f to 6723393 Compare March 27, 2026 14:01

cakebaker merged commit e104fc8 into uutils:main Mar 27, 2026
161 of 162 checks passed

Uh oh!

Conversation

RenjiSann commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

codspeed-hq bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

AldanTanneo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

AldanTanneo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

cakebaker left a comment

Choose a reason for hiding this comment

Uh oh!

RenjiSann commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

Uh oh!

cakebaker commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Mar 26, 2026 •

edited

Loading