Skip to content

Remove duplicated features#11510

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:simple-feat
Mar 27, 2026
Merged

Remove duplicated features#11510
sylvestre merged 1 commit intouutils:mainfrom
oech3:simple-feat

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 26, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 26, 2026

I hav no idea why does this break CI

@oech3 oech3 closed this Mar 26, 2026
@oech3 oech3 deleted the simple-feat branch March 26, 2026 18:01
@cakebaker
Copy link
Copy Markdown
Contributor

@oech3 The reason it breaks the CI is that we use the feature in different workflows:

$ grep "feat_os_macos" -r .github/workflows/
.github/workflows/code-quality.yml:          - { os: macos-latest   , features: feat_os_macos }
.github/workflows/l10n.yml:          - { os: macos-latest   , features: "feat_os_macos" }
.github/workflows/l10n.yml:          - { os: macos-latest   , features: "feat_os_macos" }
.github/workflows/l10n.yml:          - { os: macos-latest   , features: "feat_os_macos" }
.github/workflows/CICD.yml:#          - { os: macos-latest   , features: feat_os_macos }
.github/workflows/CICD.yml:          - { os: macos-latest   , features: feat_os_macos }
.github/workflows/CICD.yml:          - { os: macos-latest   , features: feat_os_macos }
.github/workflows/CICD.yml:          - { os: macos-latest   , target: aarch64-apple-darwin        , features: feat_os_macos, workspace-tests: true } # M1 CPU
.github/workflows/CICD.yml:          - { os: macos-latest   , target: x86_64-apple-darwin         , features: feat_os_macos, workspace-tests: true }
.github/workflows/CICD.yml:          - { os: macos-latest   , features: feat_os_macos }

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 27, 2026

@cakebaker Thankyou . I guess I forgot to push dotfiles.

@oech3 oech3 restored the simple-feat branch March 27, 2026 06:38
@oech3 oech3 reopened this Mar 27, 2026
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/rm/isatty (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will improve performance by 13.59%

⚡ 1 improved benchmark
✅ 299 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 699.2 KB 615.6 KB +13.59%

Comparing oech3:simple-feat (dd6d284) with main (3dec656)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review March 27, 2026 07:03
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 27, 2026

passed!

@sylvestre sylvestre merged commit 2b05f2f into uutils:main Mar 27, 2026
163 checks passed
@oech3 oech3 deleted the simple-feat branch March 27, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants