Skip to content

cat: avoid splice for small files#11523

Draft
oech3 wants to merge 3 commits intouutils:mainfrom
oech3:cat-small-file
Draft

cat: avoid splice for small files#11523
oech3 wants to merge 3 commits intouutils:mainfrom
oech3:cat-small-file

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 27, 2026

Closes #10835
@FidelSch Would you bench? My hyperfile is not stable.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/dd/no-allocate is now passing!

@oech3

This comment was marked as resolved.

@oech3 oech3 force-pushed the cat-small-file branch 2 times, most recently from b792e21 to 02727ea Compare March 30, 2026 07:18
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 30, 2026

CodSpeed has no change. @FidelSch Are you OK to close this and your PR?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 30, 2026

But it might needed to avoid pipe and fcntl for small files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants