uudoc: drop legacy FA4 fa class from platform icons#11641
Merged
sylvestre merged 1 commit intouutils:mainfrom Apr 5, 2026
Merged
uudoc: drop legacy FA4 fa class from platform icons#11641sylvestre merged 1 commit intouutils:mainfrom
fa class from platform icons#11641sylvestre merged 1 commit intouutils:mainfrom
Conversation
mdbook 0.5's built-in Font Awesome parser sees the leading `fa` class and defaults to type=regular, which fails to find linux/windows/apple (they live under the `brands` family) and emits hundreds of WARN lines per build. Keeping only `fa-brands fa-<icon>` lets the parser resolve the icon correctly. See https://rust-lang.github.io/mdBook/format/mdbook.html for the mdbook Font Awesome syntax.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdbook 0.5's built-in Font Awesome parser sees the leading
faclass and defaults to type=regular, which fails to find linux/windows/apple (they live under thebrandsfamily) and emits hundreds of WARN lines per build. Keeping onlyfa-brands fa-<icon>lets the parser resolve the icon correctly.See https://rust-lang.github.io/mdBook/format/mdbook.html for the mdbook Font Awesome syntax.