Skip to content

numfmt: fix zero-padding placement for negative numbers #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 2 commits into from
Apr 7, 2026
Merged

numfmt: fix zero-padding placement for negative numbers #11694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c384d40
numfmt: fix zero-padding placement before sign for negative numbers
Sim-hu Apr 7, 2026
ef9bc4d
numfmt: simplify sign handling with combined strip_prefix
Sim-hu Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/uu/numfmt/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,12 @@ fn format_string(
let padded_number = match padding {
0 => number_with_suffix,
p if p > 0 && options.format.zero_padding => {
let zero_padded = pad_string(&number_with_suffix, p as usize, '0', true);
let zero_padded = if let Some(unsigned) = number_with_suffix.strip_prefix(['-', '+']) {
let sign = &number_with_suffix[..1];
format!("{sign}{}", pad_string(unsigned, p as usize - 1, '0', true))
} else {
pad_string(&number_with_suffix, p as usize, '0', true)
};

match implicit_padding.unwrap_or(options.padding) {
0 => zero_padded,
Expand Down
1 change: 0 additions & 1 deletion tests/by-util/test_numfmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,7 +1428,6 @@ fn test_from_unit_fractional_precision_issue_11663() {
// Zero-padded `--format` places padding zeros before the sign for negative
// numbers; GNU (and C printf) puts the sign first.
#[test]
#[ignore = "GNU compat: see uutils/coreutils#11664"]
fn test_zero_pad_sign_order_issue_11664() {
new_ucmd!()
.args(&["--from=none", "--format=%018.2f", "--", "-9869647"])
Expand Down
Loading