Skip to content

numfmt:fix issue #11653 & correct test cases #11695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 2 commits into from
Apr 7, 2026
+15 −4
Merged

numfmt:fix issue #11653 & correct test cases #11695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e25ca7
fix(numfmt):fix GNU compat issue #11653 & correct test cases
THEMIScale Apr 7, 2026
26af2d5
Merge branch 'main' into main
THEMIScale Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/uu/numfmt/src/numfmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ pub fn uu_app() -> Command {
.about(translate!("numfmt-about"))
.after_help(translate!("numfmt-after-help"))
.override_usage(format_usage(&translate!("numfmt-usage")))
.allow_negative_numbers(true)
.infer_long_args(true)
.arg(
Arg::new(DEBUG)
Expand Down
18 changes: 15 additions & 3 deletions tests/by-util/test_numfmt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ fn test_invalid_arg() {
new_ucmd!().arg("--definitely-invalid").fails_with_code(1);
}

// This test failed when fixing #11653.
// Add a `--` separator to ensure floats are not rounded(it match the gnu pattern).
#[test]
fn test_should_not_round_floats() {
new_ucmd!()
.args(&["0.99", "1.01", "1.1", "1.22", ".1", "-0.1"])
.args(&["--", "0.99", "1.01", "1.1", "1.22", ".1", "-0.1"])
.succeeds()
.stdout_is("0.99\n1.01\n1.1\n1.22\n0.1\n-0.1\n");
}
Expand Down Expand Up @@ -1370,12 +1372,22 @@ fn test_null_byte_input_multiline() {
// GNU rejects `-9923868` as an invalid short option (leading `-9`) and
// requires `--` separator; uutils accepts it as a negative positional number.
#[test]
#[ignore = "GNU compat: see uutils/coreutils#11653"]
fn test_negative_number_without_double_dash_gnu_compat_issue_11653() {
new_ucmd!()
.args(&["--to=iec", "-9923868"])
.fails_with_code(1)
.stderr_contains("invalid option");
.stderr_contains("unexpected argument");
}

// https://github.com/uutils/coreutils/issues/11653
// GNU rejects `-9923868` as an invalid short option (leading `-9`) and
// requires `--` separator; uutils accepts it as a negative positional number.
#[test]
fn test_negative_number_with_double_dash_gnu_compat_issue_11653() {
new_ucmd!()
.args(&["--to=iec", "--", "-9923868"])
.succeeds()
.stdout_is("-9.5M\n");
}

// https://github.com/uutils/coreutils/issues/11654
Expand Down
Loading