Skip to content

du: remove unnecessary implementation of code()#11803

Merged
sylvestre merged 1 commit into
uutils:mainfrom
cakebaker:du_remove_unnecessary_code_impl
Apr 14, 2026
Merged

du: remove unnecessary implementation of code()#11803
sylvestre merged 1 commit into
uutils:mainfrom
cakebaker:du_remove_unnecessary_code_impl

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

The default implementation of code() in the UError trait always returns 1, so our override is redundant.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/retry is no longer failing!
Congrats! The gnu test tests/cut/cut-huge-range is now passing!

@xtqqczze
Copy link
Copy Markdown
Contributor

There's many other utilities that implement UError::code always returning 1.

@sylvestre sylvestre merged commit 9db3c1b into uutils:main Apr 14, 2026
168 of 169 checks passed
@cakebaker cakebaker deleted the du_remove_unnecessary_code_impl branch April 15, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants