ls: restore WASI ".." metadata fallback in collect_directory_entries#11930
Merged
sylvestre merged 2 commits intouutils:mainfrom Apr 22, 2026
Merged
ls: restore WASI ".." metadata fallback in collect_directory_entries#11930sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
The ls refactor in uutils#9851 dropped the WASI guard added in uutils#11633, so `ls -al` at a preopened root once again fails with "Capabilities insufficient" when stat'ing "..". Extract the logic into a small `dotdot_path` helper and add a regression test covering `ls -al`.
|
GNU testsuite comparison: |
Contributor
Author
|
note: it breaks the playground wasm test suite |
cakebaker
reviewed
Apr 22, 2026
|
|
||
| #[test] | ||
| #[cfg(target_os = "wasi")] | ||
| fn test_ls_al_no_capabilities_insufficient_on_wasi() { |
Contributor
There was a problem hiding this comment.
Are you aware that this test is currently not run in the CI?
Contributor
Hm, what does that mean? Should I wait with merging? |
cakebaker
approved these changes
Apr 22, 2026
Contributor
Author
|
this will unbreak the ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ls refactor in #9851 dropped the WASI guard added in #11633, so
ls -alat a preopened root once again fails with "Capabilities insufficient" when stat'ing "..". Extract the logic into a smalldotdot_pathhelper and add a regression test coveringls -al.