Skip to content

pinky: fix panic when outputting to /dev/full#11970

Open
hideyosh1 wants to merge 1 commit intouutils:mainfrom
hideyosh1:pinky-full
Open

pinky: fix panic when outputting to /dev/full#11970
hideyosh1 wants to merge 1 commit intouutils:mainfrom
hideyosh1:pinky-full

Conversation

@hideyosh1
Copy link
Copy Markdown

@hideyosh1 hideyosh1 commented Apr 24, 2026

  • fixes panic by replacing all println with writeln

new contributor, please be gentle

Closes #10562

- fixes panic by replacing all println with writeln
@oech3

This comment was marked as resolved.

@hideyosh1 hideyosh1 changed the title pinky: fix panic when outputting to /dev/full (#10562) pinky: fix panic when outputting to /dev/full Apr 24, 2026
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

@oech3
Copy link
Copy Markdown
Contributor

oech3 commented Apr 24, 2026

  error: empty string literal in `writeln!`
     --> src/uu/pinky/src/platform/unix.rs:235:9
      |
  235 |         writeln!(stdout().lock(), "")?;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^----^
      |                                 |
      |                                 help: remove the empty string

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 24, 2026

Merging this PR will not alter performance

✅ 289 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing hideyosh1:pinky-full (94bc512) with main (52e1bc1)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pinky > /dev/full panics

2 participants