du: propagate errors from --exclude-from instead of panicking#11996
Merged
cakebaker merged 5 commits intoApr 27, 2026
Conversation
|
GNU testsuite comparison: |
Contributor
|
Can you please add a test to ensure we don't regress in the future? Thanks. |
Contributor
Author
Sure! Done |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
Sorry, my bad: forgot to double check the error message 😅 It's fixed now |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11924
Fixes #11925
du -X <file>panicked on two failure modes when reading the--exclude-fromfile:Missing file (du -X with a nonexistent file panics #11924):
$ du -X nonexistent-filethread 'main' panicked at src/uu/du/src/du.rs:759:37: no such file: Os { code: 2, kind: NotFound, ... } Aborted (core dumped)GNU
duprints a clean error and exits non-zero.Per-line I/O error (du -X /proc/self/mem panics #11925), e.g. a pseudo-file that fails on read:
$ du -X /proc/self/memthread 'main' panicked at src/uu/du/src/du.rs:763:20: Could not parse line: Os { code: 5, kind: Uncategorized, ... }Both now exit with code 1 and print to stderr (
du: No such file or directory,du: Input/output error,du: Permission denied — message follows the OS error kind).The call site was also switched from
.flat_map(file_as_vec)to a.map(...).collect::<UResult<_>>()?chain, becauseflat_mapover aResult-returning function silently dropsErr(zero items) — hidingany I/O failure instead of reporting it.