Skip to content

chroot: start removing unsafe#12053

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:chroot-unsafe
Apr 28, 2026
Merged

chroot: start removing unsafe#12053
sylvestre merged 1 commit into
uutils:mainfrom
oech3:chroot-unsafe

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Apr 28, 2026

Some unsafes need more refactoring

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/basenc/bounded-memory is now passing!

@oech3 oech3 marked this pull request as ready for review April 28, 2026 09:32
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will degrade performance by 23.82%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_utf8_locale 16.1 ms 15.4 ms +4.88%
Memory cp_recursive_deep_tree[(120, 4)] 532.7 KB 699.2 KB -23.82%

Comparing oech3:chroot-unsafe (72dd297) with main (ec72d08)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
Copy link
Copy Markdown
Contributor

@oech3 i wrote this graph to keep track this effort: https://github.com/uutils/coreutils-tracking/#unsafe-usage-evolution

@sylvestre sylvestre merged commit 90af168 into uutils:main Apr 28, 2026
168 of 169 checks passed
@oech3 oech3 deleted the chroot-unsafe branch April 28, 2026 10:56
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 28, 2026

Nice! It would be nice if we count unsafes in production code and unsafes in test code.

@sylvestre
Copy link
Copy Markdown
Contributor

@oech3 done https://github.com/uutils/coreutils-tracking/#unsafe-usage-evolution

(are you on discord btw?)

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Apr 28, 2026

I'm not on discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants