Skip to content

test_test.rs: remove unsafe #12055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 1 commit into from
Apr 28, 2026
+5 −9
Merged

test_test.rs: remove unsafe #12055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions tests/by-util/test_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,22 +731,18 @@ fn test_file_owned_by_egid() {
// /tmp directory will have a different gid than the current egid (due to
// the sticky bit set on the /tmp directory). Fix this before running the
// test command.
use std::ffi::CString;
use std::os::unix::ffi::OsStrExt;
use std::os::unix::fs::MetadataExt;
use uucore::process::getegid;
let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;

let metadata = at.metadata("regular_file");
let file_gid = metadata.gid();
let user_gid = getegid();
let file_gid = rustix::fs::Gid::from_raw(metadata.gid());
let user_gid = rustix::process::getegid();

if user_gid != file_gid {
let file_metadata_uid = metadata.uid();
let path = CString::new(at.plus("regular_file").as_os_str().as_bytes()).expect("bad path");
let r = unsafe { libc::chown(path.as_ptr(), file_metadata_uid, user_gid) };
assert_ne!(r, -1);
let file_uid = rustix::fs::Uid::from_raw(metadata.uid());
let path = at.plus("regular_file");
rustix::fs::chown(&path, Some(file_uid), Some(user_gid)).expect("chown failed");
}

scene.ucmd().args(&["-G", "regular_file"]).succeeds();
Expand Down
Loading