ls: fix comparisons in version sorting and recursive mode#12108
Merged
Conversation
Depending on the sorting it would not, so it could recurse back through `..`. Backported from another PR of mine.
Also fixes the fact that version sorting had incorrect edge cases due to wrong name passing.
|
GNU testsuite comparison: |
Contributor
Author
|
It seems bindgen broke in OpenBSD (it seems related to indexmap dep?), but it's unrelated to the PR. If we see it in further CI runs we should look into it. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version sorting was being fed the incorrect values, as it expected file names but got paths, breaking the special-casing logic. This at some point was actually the expected behavior, because we asserted it in the tests; when triaging the associated issue, I reproduced we were mismatched with GNU on my Ubuntu LTS machine, so I'm submitting the fix. Also fixes a similar sorting bug in
--recursive, backported from 26db61c.Fixes #12058.