factor: emit GNU 9.11 'is not a valid positive integer' for stdin input#12137
Merged
Conversation
GNU's factor.c routes both stdin and command-line input through the same print_factors() and reports invalid input as factor: 'X' is not a valid positive integer Match that wording exactly so the new GNU 9.11 'nul4' test passes and the 'cont' test no longer needs the warning/invalid-digit hunk in tests_factor_factor.pl.patch.
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
fix/factor-9.11-error-message
branch
from
27cd7e7 to
0425b96
Compare
Contributor
Great :) |
nonontb
pushed a commit
to nonontb/coreutils
that referenced
this pull request
May 28, 2026
…ut (uutils#12137) * factor: emit GNU's 'X is not a valid positive integer' wording GNU's factor.c routes both stdin and command-line input through the same print_factors() and reports invalid input as factor: 'X' is not a valid positive integer Match that wording exactly so the new GNU 9.11 'nul4' test passes and the 'cont' test no longer needs the warning/invalid-digit hunk in tests_factor_factor.pl.patch. * Add 'cmdline' to spell-checker ignore list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command-line arguments keep the historical 'warning: ...: invalid digit found in string' wording so 'tests/factor/factor.pl' cont and nul4 both pass.