Skip to content

factor: remove unsafe str::from_utf8_unchecked#12142

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:factor-unsafe
May 5, 2026
Merged

factor: remove unsafe str::from_utf8_unchecked#12142
cakebaker merged 1 commit into
uutils:mainfrom
oech3:factor-unsafe

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 4, 2026

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 4, 2026

Merging this PR will not alter performance

✅ 311 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:factor-unsafe (6fe8c3e) with main (c23dc67)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (f7ba1f9) during the generation of this report, so c23dc67 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

@oech3 oech3 marked this pull request as ready for review May 4, 2026 13:25
@oech3 oech3 force-pushed the factor-unsafe branch 2 times, most recently from f09ce40 to 313c198 Compare May 4, 2026 13:58
Comment thread src/uu/factor/src/factor.rs Outdated
@oech3 oech3 force-pushed the factor-unsafe branch from 313c198 to ae3034c Compare May 4, 2026 15:11
Comment thread src/uu/factor/src/factor.rs
@oech3 oech3 force-pushed the factor-unsafe branch from ae3034c to e2d0deb Compare May 4, 2026 20:47
@oech3 oech3 force-pushed the factor-unsafe branch from e2d0deb to 6fe8c3e Compare May 5, 2026 10:55
@cakebaker cakebaker merged commit 39364b6 into uutils:main May 5, 2026
178 of 231 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the factor-unsafe branch May 5, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants