Skip to content

cksum: Introduce HashLength newtype to avoid byte/bit misuse#12235

Merged
cakebaker merged 1 commit into
uutils:mainfrom
RenjiSann:cksum-uniform-bitlength
May 14, 2026
Merged

cksum: Introduce HashLength newtype to avoid byte/bit misuse#12235
cakebaker merged 1 commit into
uutils:mainfrom
RenjiSann:cksum-uniform-bitlength

Conversation

@RenjiSann
Copy link
Copy Markdown
Collaborator

Fix for #11500

@RenjiSann RenjiSann requested a review from sylvestre May 11, 2026 13:19
@RenjiSann RenjiSann force-pushed the cksum-uniform-bitlength branch from 9c04461 to 733b4ec Compare May 11, 2026 13:35
Comment thread src/uucore/src/lib/features/checksum/mod.rs Outdated
Comment thread src/uucore/src/lib/features/checksum/mod.rs Outdated
@RenjiSann RenjiSann force-pushed the cksum-uniform-bitlength branch from 733b4ec to 1b3469e Compare May 14, 2026 09:29
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will improve performance by 3.64%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 315 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ls_recursive_balanced_tree[(6, 4, 15)] 50.9 ms 48.9 ms +4.01%
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 25.9 ms 25 ms +3.28%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing RenjiSann:cksum-uniform-bitlength (1b3469e) with main (cb833df)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker cakebaker merged commit 6a942ba into uutils:main May 14, 2026
170 of 171 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@RenjiSann RenjiSann deleted the cksum-uniform-bitlength branch May 15, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants