Skip to content

replace nix getgroups by rustix#12269

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:getgroups
May 13, 2026
Merged

replace nix getgroups by rustix#12269
sylvestre merged 1 commit into
uutils:mainfrom
oech3:getgroups

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 13, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/pid-pipe. tests/tail/pid-pipe is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@oech3 oech3 marked this pull request as ready for review May 13, 2026 03:14
@xtqqczze
Copy link
Copy Markdown
Contributor

Out of interest, what is the benefit of replacing nix with rustix in tests?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 13, 2026 via email

@sylvestre sylvestre merged commit eca185b into uutils:main May 13, 2026
168 of 169 checks passed
@oech3 oech3 deleted the getgroups branch May 13, 2026 05:42
@xtqqczze
Copy link
Copy Markdown
Contributor

To be honest, removing nix is likely to only make a very marginal gain to build times. You can investigate using:

cargo build --timings

@sylvestre
Copy link
Copy Markdown
Contributor

to me, it is to avoid having several crates doing the same things. makes the code nicer and more consistent.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 13, 2026

How about removing unsafe libc (allowing nix), and removing nix later?

@xtqqczze
Copy link
Copy Markdown
Contributor

How about removing unsafe libc (allowing nix), and removing nix later?

Let's move that discussion to this issue: #9549.

nonontb pushed a commit to nonontb/coreutils that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants