Skip to content

sort: replace nix feature resource with rustix#12275

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:nix-resource
May 14, 2026
Merged

sort: replace nix feature resource with rustix#12275
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:nix-resource

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

Avoid compiling the nix feature resource.

@xtqqczze xtqqczze marked this pull request as draft May 13, 2026 11:31
@oech3
Copy link
Copy Markdown
Contributor

oech3 commented May 13, 2026

I guess libc is still dep of rustix on non-Linux.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@xtqqczze xtqqczze changed the title sort: replace nix with rustix sort: replace nix feature resource with rustix May 13, 2026
@xtqqczze
Copy link
Copy Markdown
Contributor Author

I guess libc is still dep of rustix on non-Linux.

libc is only a direct dependency because we use it in current_open_fd_count.

@xtqqczze xtqqczze marked this pull request as ready for review May 13, 2026 12:11
@xtqqczze
Copy link
Copy Markdown
Contributor Author

@cakebaker cakebaker merged commit 7a83db4 into uutils:main May 14, 2026
170 of 171 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@xtqqczze xtqqczze deleted the nix-resource branch May 14, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants