kill: replace nix::sys::signal with rustix::process#12326
Open
mattsu2020 wants to merge 2 commits into
Open
Conversation
Replace nix dependency with rustix in the kill utility. The migration uses rustix's explicitly typed per-case kill APIs (kill_process, kill_process_group, kill_current_process_group) and their test_kill_* variants for signal 0 (EXIT), instead of nix's single signal::kill function with Option<Signal>. Key changes: - Dispatch based on pid sign (>0 process, <0 process group, =0 current process group) and signal value (=0 uses test_kill_* variants) - Use Pid::from_raw (safe) instead of Pid::from_raw_unchecked - Guard against i32::MIN overflow with checked_neg() - Use Signal::from_raw_unchecked only for validated signal numbers
|
GNU testsuite comparison: |
Merging this PR will improve performance by 13.71%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | cp_recursive_deep_tree[(120, 4)] |
699.2 KB | 562.5 KB | +24.31% |
| ⚡ | Simulation | ls_recursive_balanced_tree[(6, 4, 15)] |
50.9 ms | 48.9 ms | +4.01% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mattsu2020:kill_rustix (22377dc) with main (d09f351)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nixdependency withrustixin thekillutility, continuing the ongoing effort to migrate away from nix (see chore(deps): update rust crate clap to v4.5.30 #7317)kill_process,kill_process_group,kill_current_process_group) and theirtest_kill_*variants for signal 0 (EXIT), instead of nix's singlesignal::kill(pid, Option<Signal>)function>0process,<0process group,=0current process group) and signal value (=0usestest_kill_*variants)i32::MINoverflow withchecked_neg()when negating negative PIDsPid::from_raw()withexpect()instead ofPid::from_raw_uncheckedTest plan
cargo test -p coreutils --test tests --features kill -- test_kill_)cargo build -p uu_kill)