nohup: create nohup.out with mode 0600#12339
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
POSIX nohup creates the output file with permissions that block other users from reading it. We were leaving the mode at the process umask default, so on a typical system with umask 022 the file would land at 0644 and any other local user could read whatever the detached job logged. That's not great on multi-user hosts. Pass `.mode(0o600)` on the OpenOptions so newly-created `nohup.out` files start out as owner-only. Existing files keep their current permissions, which matches GNU. Closes uutils#10021. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10021.
POSIX nohup creates the output file as owner-only so other local users can't read what the detached job logs. We were leaving the mode at the process umask, so on a host with the typical umask of 022 the file would land at 0644 and anyone could read it.
Pass
.mode(0o600)on theOpenOptions. The mode only applies to newly-created files; ifnohup.outalready exists its permissions are left alone, which matches GNU.Verified locally: