Skip to content

buf_copy.rs: don't test a trivial io::copy wrapper #12344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
May 17, 2026
+1 −28
Merged

buf_copy.rs: don't test a trivial io::copy wrapper #12344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions src/uucore/src/lib/features/buf_copy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ pub mod other;
pub use other::copy_stream;

#[cfg(test)]
#[cfg(any(target_os = "linux", target_os = "android"))] // copy_stream is a thin wrapper for io::copy. nothing to test...
mod tests {
use super::*;
use std::fs::File;
use tempfile::tempdir;

#[cfg(target_os = "linux")]
use {
std::fs::OpenOptions,
std::{
Expand All @@ -36,7 +36,6 @@ mod tests {

use std::io::{Read, Write};

#[cfg(target_os = "linux")]
fn new_temp_file() -> File {
let temp_dir = tempdir().unwrap();
OpenOptions::new()
Expand All @@ -49,7 +48,6 @@ mod tests {
}

#[test]
#[cfg(unix)]
fn test_copy_stream() {
let mut dest_file = new_temp_file();

Expand All @@ -71,29 +69,4 @@ mod tests {

assert_eq!(buf, data);
}

#[test]
#[cfg(not(unix))]
// Test for non-unix platforms. We use regular files instead.
fn test_copy_stream() {
let temp_dir = tempdir().unwrap();
let src_path = temp_dir.path().join("src.txt");
let dest_path = temp_dir.path().join("dest.txt");

let mut src_file = File::create(&src_path).unwrap();
let mut dest_file = File::create(&dest_path).unwrap();

let data = b"Hello, world!";
src_file.write_all(data).unwrap();
src_file.sync_all().unwrap();

let mut src_file = File::open(&src_path).unwrap();
copy_stream(&mut src_file, &mut dest_file).unwrap();

let mut dest_file = File::open(&dest_path).unwrap();
let mut buf = Vec::new();
dest_file.read_to_end(&mut buf).unwrap();

assert_eq!(buf, data);
}
}
Loading