pipes.rs: make splice_exact robust against splice failure#12387
Closed
oech3 wants to merge 1 commit into
Closed
Conversation
7b4d74a to
f6cce09
Compare
Contributor
Author
|
Impossible to include fallback to the fn... I'll dedup the code at different PR. |
This comment was marked as outdated.
This comment was marked as outdated.
|
GNU testsuite comparison: |
ab6b8df to
629ebc8
Compare
Contributor
Author
|
I found better way. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error is very rare (and maybe impossible to add regression test).
But if N-th splice of
splice_exactfailed, the length used by write fallback is wrong. Thus, it should return length failed to splice.Better replacement for #12315