Skip to content

pipes.rs: make splice_exact robust against splice failure#12387

Closed
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:send-n-broker
Closed

pipes.rs: make splice_exact robust against splice failure#12387
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:send-n-broker

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 19, 2026

This error is very rare (and maybe impossible to add regression test).
But if N-th splice of splice_exact failed, the length used by write fallback is wrong. Thus, it should return length failed to splice.

Better replacement for #12315

@oech3 oech3 force-pushed the send-n-broker branch 7 times, most recently from 7b4d74a to f6cce09 Compare May 19, 2026 12:52
@oech3 oech3 marked this pull request as ready for review May 19, 2026 13:34
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 19, 2026

Impossible to include fallback to the fn... I'll dedup the code at different PR.

@oech3

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

@oech3 oech3 force-pushed the send-n-broker branch 2 times, most recently from ab6b8df to 629ebc8 Compare May 20, 2026 07:35
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 20, 2026

I found better way. Closing.

@oech3 oech3 closed this May 20, 2026
@oech3 oech3 deleted the send-n-broker branch May 20, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant