Skip to content

pipes.rs: simplify trait and match#12397

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:pipe-t
May 20, 2026
Merged

pipes.rs: simplify trait and match#12397
cakebaker merged 1 commit into
uutils:mainfrom
oech3:pipe-t

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 20, 2026

Split trivial changes from other PRs.

  • io::Pipe* is the most common tool at here. So import at top.
  • pipe size is same for reader/writer. So using pair for simplicity does not cause any confusion.
  • Remove unused Read
  • simplify match

@oech3 oech3 marked this pull request as ready for review May 20, 2026 03:16
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/pipe-f2. tests/tail/pipe-f2 is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout-group (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (was skipped on 'main', now failing)

@cakebaker cakebaker merged commit 83b09a4 into uutils:main May 20, 2026
170 of 171 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the pipe-t branch May 20, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants