buf_copy/linux.rs: replace flush by raw write#12401
Open
oech3 wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
Contributor
Contributor
Author
|
Stream does NOT mean it is pipe. Please remove PipeReader.
|
Contributor
|
Contributor
Author
|
Well, if our cp /dev/stdin is lacking support for non-pipe stream, we should support it too. No benefit to restrict.
cc: reviers Please merge this and ignore another one.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flush is just an workaround to avoid wrong order of output. Proper solution is writing to fd without buffering.
(This matches with
GNU cp's unbufferedcp /dev/stdin ....)Closes #12405