Skip to content

pipes.rs: simplify dev_null & remove crate name from comment #12408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
May 21, 2026
+4 −8
Merged

pipes.rs: simplify dev_null & remove crate name from comment #12408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/uucore/src/lib/features/pipes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source code.

//! Thin zero-copy-related wrappers around functions from the `rustix` crate.
//! Thin zero-copy-related wrappers around functions.

#[cfg(any(target_os = "linux", target_os = "android"))]
use rustix::pipe::{SpliceFlags, fcntl_setpipe_size};
Expand Down Expand Up @@ -39,7 +39,7 @@ pub fn pipe<const SIZE_REQUIRED: bool>(s: usize) -> std::io::Result<(PipeReader,
Ok(pair)
}

/// Less noisy wrapper around [`rustix::pipe::splice`].
/// Less noisy wrapper around splice syscall
///
/// Up to `len` bytes are moved from `source` to `target`. Returns the number
/// of successfully moved bytes.
Expand Down Expand Up @@ -245,14 +245,10 @@ pub fn dev_null() -> Option<File> {
.ok()?;
let stat = rustix::fs::fstat(&null).ok()?;
let dev = stat.st_rdev;
if (rustix::fs::major(dev), rustix::fs::minor(dev)) == (1, 3) {
Some(null)
} else {
None
}
((rustix::fs::major(dev), rustix::fs::minor(dev)) == (1, 3)).then_some(null)
}

// Less noisy wrapper around [`rustix::pipe::tee`]
// Less noisy wrapper around tee syscall
#[inline]
#[cfg(any(target_os = "linux", target_os = "android"))]
pub fn tee(source: &impl AsFd, target: &impl AsFd, len: usize) -> rustix::io::Result<usize> {
Expand Down
Loading