refactor: add TeeState enum#12423
Closed
xtqqczze wants to merge 1 commit into
Closed
Conversation
Contributor
|
We use Ok(()) and Err(()) only. No benefit by your change. |
oech3
reviewed
May 21, 2026
| if safe_partial_send && tee(&p_read, &stdout, MAX_ROOTLESS_PIPE_SIZE).is_ok() { | ||
| while let Ok(1..) = tee(&p_read, &stdout, MAX_ROOTLESS_PIPE_SIZE) {} | ||
| if safe_partial_send { | ||
| while let TeeState::Ended(_) = tee(&p_read, &stdout, MAX_ROOTLESS_PIPE_SIZE) {} |
Contributor
There was a problem hiding this comment.
Do you want do same things for all of standard read & write loop?!
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #12419
Previously,
pipes::teereturned arustix::io::Result, which does not align with the intended abstraction boundary. Since theErrvariant was always discarded at the call sites, the implementation can be simplified by using an enum instead.