Skip to content

pipes.rs: replace bool by Result<(),()>#12454

Draft
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:splice-bool
Draft

pipes.rs: replace bool by Result<(),()>#12454
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:splice-bool

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 23, 2026

Fix true to check that fallback is needed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/csplit/csplit-heap is now passing!
Congrats! The gnu test tests/cut/bounded-memory is now passing!

@oech3 oech3 marked this pull request as ready for review May 23, 2026 14:42
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 23, 2026

Actually, I don't like this diff

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 24, 2026

#12463 should be merged before this.

@oech3 oech3 marked this pull request as draft May 24, 2026 12:43
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 24, 2026

Merging this PR will degrade performance by 3.34%

❌ 1 regressed benchmark
✅ 318 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_long_line[10000] 424 µs 438.7 µs -3.34%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:splice-bool (6fdc839) with main (913c6c2)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant