Skip to content

pipes.rs: dedup code by including fallback to splice_exact#12472

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:splice-exact-dedup
Open

pipes.rs: dedup code by including fallback to splice_exact#12472
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:splice-exact-dedup

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 24, 2026 •
edited
Loading

I noticed that it is able to include read/write fallback to splice_exact by #12451 (comment) .

@oech3 oech3 force-pushed the splice-exact-dedup branch 2 times, most recently from 63432cc to c547256 Compare May 24, 2026 22:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 24, 2026 •
edited
Loading

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as ready for review May 24, 2026 23:55
xtqqczze
xtqqczze reviewed May 25, 2026
View reviewed changes
Comment thread src/uucore/src/lib/features/pipes.rs Outdated
@oech3 oech3 force-pushed the splice-exact-dedup branch 3 times, most recently from dc3fb12 to 926dd5e Compare May 25, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @xtqqczze