Skip to content

simplify uucore::pipes::send_n_bytes#12491

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:fuse
May 27, 2026
Merged

simplify uucore::pipes::send_n_bytes#12491
cakebaker merged 1 commit into
uutils:mainfrom
oech3:fuse

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 27, 2026

  • put fcntl on outside of nest
  • remove duplicated 1st splice
  • use true for positive meaning
  • dedup might_fuse
  • reduce nest

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 27, 2026

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:fuse (1ed93c8) with main (8de3238)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (a17c0be) during the generation of this report, so 8de3238 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skip an intermittent issue tests/cut/bounded-memory (was skipped on 'main', now failing)
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@oech3 oech3 marked this pull request as ready for review May 27, 2026 13:12
Comment thread src/uucore/src/lib/features/pipes.rs Outdated
@cakebaker cakebaker merged commit e451ddf into uutils:main May 27, 2026
171 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the fuse branch May 27, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants