wasi: clean up core platform abstractions#12503
Conversation
|
closes #12427 |
|
GNU testsuite comparison: |
| pub type Pid = u64; | ||
|
|
||
| #[cfg(target_os = "wasi")] | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
please refactor to avoid the allow dead code
There was a problem hiding this comment.
Okay, I think we can just remove ProcessChecker for WASI. Since the original PR is from a couple months ago, I don't remember why exactly it was added.
Merging this PR will degrade performance by 14.62%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
The command fails during argument validation before reading stdin, so remove unnecessary piped input that could hit EPIPE.
This is the first PR split out from the larger WASI changes in #11712.
Changes
rustix::fs::Statfor WASIFileInformationso same-file checks use device/inode identity instead of a file-type/size heuristic.read_fs_list()returnUResult<Vec<MountInfo>>on WASI, matching other platforms while still returning an empty mount list.OsStrExt/OsStringExtimports inenv.tailprocess-check stubs so the shared follow code compiles while--pidremains unsupported.OwnedFileDescriptorOrHandle::into_stdio().