Skip to content

tee: restrict to NamedReader#12510

Merged
cakebaker merged 1 commit into
uutils:mainfrom
oech3:tee-nr
May 29, 2026
Merged

tee: restrict to NamedReader#12510
cakebaker merged 1 commit into
uutils:mainfrom
oech3:tee-nr

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 29, 2026

Other Read should not be accepted by copy_unbuffered since we need to show error, etc...

@oech3 oech3 marked this pull request as ready for review May 29, 2026 03:28
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 29, 2026

Merging this PR will degrade performance by 14.62%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 317 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation true_consecutive_calls 170.3 ns 199.4 ns -14.62%
Simulation false_consecutive_calls 170.3 ns 199.4 ns -14.62%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:tee-nr (ee78a86) with main (55549fa)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@cakebaker cakebaker merged commit e50a178 into uutils:main May 29, 2026
172 of 173 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@oech3 oech3 deleted the tee-nr branch May 29, 2026 08:20
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 29, 2026

would you review #11943 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants