uucore: fix C.UTF-8 locale incorrectly detected as ASCII#12525
Open
mufeedali wants to merge 3 commits into
Open
uucore: fix C.UTF-8 locale incorrectly detected as ASCII#12525mufeedali wants to merge 3 commits into
mufeedali wants to merge 3 commits into
Conversation
C.UTF-8 was treated as a byte-comparison locale because of an early return that matched on "C" before checking the ".UTF-8" encoding suffix. This caused ls to escape non-ASCII filename characters and expr to use byte-level operations on multi-byte data. Remove the early return so C.UTF-8 and POSIX.UTF-8 are correctly detected as UTF-8 encoding. Add a locale-name guard to init_locale_collation() so sort still uses byte comparison for these locales (C/POSIX collation rules apply regardless of encoding).
Contributor
|
could you please add tests to make sure we don't regress? thanks |
Author
|
Makes sense, will add |
|
GNU testsuite comparison: |
Author
|
Added regression tests. |
Merging this PR will improve performance by 3.11%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C.UTF-8 was treated as a byte-comparison locale because of an early return that matched on "C" before checking the ".UTF-8" encoding suffix. This caused
lsto escape non-ASCII filename characters and expr to use byte-level operations on multi-byte data.Remove the early return so C.UTF-8 and POSIX.UTF-8 are correctly detected as UTF-8 encoding. Add a locale-name guard to init_locale_collation() so sort still uses byte comparison for these locales (C/POSIX collation rules apply regardless of encoding).