chown: restrict no-dereference symlink ctime test to Linux#12556
Merged
sylvestre merged 2 commits intoJun 3, 2026
Conversation
|
GNU testsuite comparison: |
rossilor95
force-pushed
the
fix-test-chown-no-recursive-ln-dir
branch
from
af8b172 to
3ca9ee0
Compare
sylvestre
reviewed
Jun 2, 2026
|
|
||
| #[test] | ||
| #[cfg(unix)] | ||
| #[cfg(target_os = "linux")] |
Contributor
There was a problem hiding this comment.
i think we want not OpenBSD as unix implies mac and it works there
Contributor
Author
There was a problem hiding this comment.
Thanks for your review! I applied the change, should be correct now
rossilor95
force-pushed
the
fix-test-chown-no-recursive-ln-dir
branch
from
3ca9ee0 to
fa6cbd2
Compare
The test chowns a symlink to its current owner (a no-op) and asserts the symlink's ctime advanced. Most unix systems (including Linux and macOS) bump ctime on a same-owner lchown, but OpenBSD does not, so the assertion fails there. Gate the test (and its MetadataExt import) behind cfg(all(unix, not(target_os = "openbsd"))).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12546
test_chown_no_dereference_symlink_to_dirfails on OpenBSD CI.The test chowns a symlink to its current owner (a no-op) and asserts the
symlink's
ctimeadvanced. Linux bumpsctimeon a same-ownerchown;while OpenBSD doesn't, so the test fails.