stat: fix char-boundary panic on an invalid directive after a multibyte char#12617
Open
leeewee wants to merge 1 commit into
Open
stat: fix char-boundary panic on an invalid directive after a multibyte char#12617leeewee wants to merge 1 commit into
leeewee wants to merge 1 commit into
Conversation
…te char `stat -c '€%-'` (a multibyte char immediately before an invalid `%` directive) aborted with "byte index N is not a char boundary". The format parser tracks positions as char indices, but `check_bound` built its "invalid directive" message by byte-slicing the format string, so a preceding multibyte char made the byte index land mid-UTF-8. Build the directive substring by chars instead of byte-slicing, so the invalid-directive error is reported (exit 1) like GNU instead of crashing.
leeewee
force-pushed
the
stat-fix-directive-char-boundary
branch
from
3d92d37 to
1bb9ea7
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12616
stat -c '€%-'(a multibyte char before an invalid%directive) aborted with "byte index N is not a char boundary":check_boundbyte-sliced the format string using char indices, splitting the multibyte char.Build the directive substring by chars instead of byte-slicing, so the invalid directive is reported (exit 1) like GNU instead of crashing. Adds a regression test.