ln: don't panic on --relative with a parentless target#12631
Open
leeewee wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
`ln -rsfT SRC /` (and `… ""`) aborted with an Option::unwrap panic before any filesystem operation: relative_path computed the destination's parent with `dst.parent().unwrap()`, but Path::parent() is None for a parentless destination (`/`, `""`, or a bare Windows prefix). Match `dst.parent()` as part of the guard and fall through to the non-relative `src` when it is None, so the caller reports the usual error (exit 1) instead of crashing.
439fca7 to
0bae620
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12628
ln -rsfT SRC /(and… "") aborted with anOption::unwrap()panic before any filesystem operation:relative_pathcomputed the destination's parent withdst.parent().unwrap(), butPath::parent()isNonefor a parentless destination (/,"", or a bare Windows prefix).Fold
dst.parent()into the guard and fall through to the non-relativesrcwhen it'sNone, so the caller reports the usual error (exit 1) instead of crashing. Adds a regression test.